Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.4.x] Improve support for Python 3.12 #165

Merged
merged 5 commits into from
Oct 30, 2023
Merged

[1.4.x] Improve support for Python 3.12 #165

merged 5 commits into from
Oct 30, 2023

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Oct 26, 2023 •
edited
Loading

Description

1.4.x backport of #164 plus other fixes required for Python 3.12

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Oct 26, 2023
@jaimergp
Copy link
Contributor Author

@xhochy, we can try this backport directly on the feedstock as a patch. If that works, we can cut a patch release for the 1.4.x branch.

@jaimergp jaimergp marked this pull request as ready for review October 26, 2023 09:25
@jaimergp jaimergp requested a review from a team as a code owner October 26, 2023 09:25
xhochy
xhochy approved these changes Oct 26, 2023
View reviewed changes
Copy link

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@jaimergp jaimergp merged commit b5d45ce into conda:1.4.x Oct 30, 2023
7 of 8 checks passed
@jaimergp jaimergp mentioned this pull request Dec 10, 2023
Merged
3 tasks
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Oct 31, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ngoldbaum ngoldbaum ngoldbaum left review comments

@xhochy xhochy xhochy approved these changes

@jezdez jezdez jezdez approved these changes

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
🔎 Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jaimergp @jezdez @xhochy @ngoldbaum @conda-bot