Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.12 #164

Merged
merged 20 commits into from
Dec 11, 2023
Merged

Add support for Python 3.12 #164

merged 20 commits into from
Dec 11, 2023

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Oct 25, 2023

Description

Supersedes #163. Apparently the C extension on Windows does not compile for 3.12 (see issues in feedstock).

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@jaimergp jaimergp requested a review from a team as a code owner October 25, 2023 08:52
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Oct 25, 2023
@jaimergp jaimergp mentioned this pull request Oct 25, 2023
3 tasks
@jaimergp
Copy link
Contributor Author

Not seeing the same errors as in the feedstock, as it compiles, but the extension does fail to run later in the tests:

            # winshortcut is a windows-only C extension! create_shortcut has this API
            # Notice args must be passed as positional, no keywords allowed!
            # winshortcut.create_shortcut(path, description, filename, arguments="",
            #                             workdir=None, iconpath=None, iconindex=0, app_id="")
>           create_shortcut(
                target_path,
                self._shortcut_filename(ext=""),
                str(path),
                " ".join(arguments),
                working_dir,
                icon,
                0,
                self._app_user_model_id(),
            )
E           SystemError: argument 1 (impossible<bad format char>)

@jaimergp
Copy link
Contributor Author

Ok, that seems to work! Errors are due to activation not working because we are installing conda in a non-conventional way to bypass the cyclical dependency between conda and menuinst.

@xhochy, if you have some time, can you take a look at the code? I'm mostly pushing buttons til it works here 😂

@jaimergp
Copy link
Contributor Author

Can I get a review here @conda/conda-core? It's essentially the same as #165, and it's blocking conda/conda#13073

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to manually modify the CHANGELOG now that we use rever?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah i see, this is effectively just merging 1.4.x into main

@jaimergp jaimergp merged commit 0530802 into conda:main Dec 11, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants