-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.12 #164
Conversation
Not seeing the same errors as in the feedstock, as it compiles, but the extension does fail to run later in the tests:
|
Ok, that seems to work! Errors are due to activation not working because we are installing conda in a non-conventional way to bypass the cyclical dependency between conda and menuinst. @xhochy, if you have some time, can you take a look at the code? I'm mostly pushing buttons til it works here 😂 |
Can I get a review here @conda/conda-core? It's essentially the same as #165, and it's blocking conda/conda#13073 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to manually modify the CHANGELOG now that we use rever?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah i see, this is effectively just merging 1.4.x
into main
Description
Supersedes #163. Apparently the C extension on Windows does not compile for 3.12 (see issues in feedstock).
Checklist - did you ...
news
directory (using the template) for the next release's release notes?