Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing spec testing flag_overrides #26

Closed
wants to merge 2 commits into from
Closed

Add failing spec testing flag_overrides #26

wants to merge 2 commits into from

Conversation

irwalker
Copy link

@irwalker irwalker commented Jun 20, 2023

Describe the purpose of your pull request

Added spec demonstrating flag_overrides parameter is broken. Not intending for this to be merged, just trying to demonstrate the issue.

Related issues (only if applicable)

Issue: #25

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

@irwalker irwalker requested a review from a team as a code owner June 20, 2023 23:06
@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@irwalker
Copy link
Author

Not sure how this PR is green as the spec fails when I run it locally 😕

  1) ConfigCat::ConfigCatClient test flag_overrides
     Failure/Error: @_override_data_source = options.flag_overrides.create_data_source(@log)

     NoMethodError:
       undefined method `create_data_source' for #<ConfigCat::LocalDictionaryDataSource:0x00007f9a6d70f300>
     # ./lib/configcat/configcatclient.rb:67:in `initialize'
     # ./lib/configcat/configcatclient.rb:39:in `new'
     # ./lib/configcat/configcatclient.rb:39:in `block in get'
     # ./lib/configcat/configcatclient.rb:27:in `synchronize'
     # ./lib/configcat/configcatclient.rb:27:in `get'
     # ./spec/configcat/configcatclient_spec.rb:291:in `block (2 levels) in <top (required)>'

Finished in 0.02386 seconds (files took 0.25324 seconds to load)
21 examples, 1 failure

@z4kn4fein
Copy link
Member

Not sure how this PR is green as the spec fails when I run it locally 😕

  1) ConfigCat::ConfigCatClient test flag_overrides
     Failure/Error: @_override_data_source = options.flag_overrides.create_data_source(@log)

     NoMethodError:
       undefined method `create_data_source' for #<ConfigCat::LocalDictionaryDataSource:0x00007f9a6d70f300>
     # ./lib/configcat/configcatclient.rb:67:in `initialize'
     # ./lib/configcat/configcatclient.rb:39:in `new'
     # ./lib/configcat/configcatclient.rb:39:in `block in get'
     # ./lib/configcat/configcatclient.rb:27:in `synchronize'
     # ./lib/configcat/configcatclient.rb:27:in `get'
     # ./spec/configcat/configcatclient_spec.rb:291:in `block (2 levels) in <top (required)>'

Finished in 0.02386 seconds (files took 0.25324 seconds to load)
21 examples, 1 failure

Hi @irwalker, thanks for pointing this out! I had to manually enable the CI actions for this PR, which is why you didn't see the failures yet. We are started working on the fix.

@irwalker
Copy link
Author

Closing as this was mentioned in the Changelog

@irwalker irwalker closed this Jun 21, 2023
@irwalker irwalker deleted the iainwalker/failing-local-overrides-spec branch June 21, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants