Fix Protobuf field transform to use schema from SR #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
|
|
||
| async toFileDesc(client: Client, info: SchemaInfo): Promise<DescFile> { | ||
| const value = this.schemaToDescCache.get(stringify(info.schema)) | ||
| if (value != null) { |
There was a problem hiding this comment.
Could just be if (value)
There was a problem hiding this comment.
Thanks, I think I'll leave it as is since the code prefers explicit checks in lots of places and I'd rather not change them all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Protobuf field transform to use schema from SR. Previously the code was using the schema from the local Proto registry instead of from SR.