-
Notifications
You must be signed in to change notification settings - Fork 20
Add dependent admin client #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎉 All Contributor License Agreements have been signed. Ready to merge. |
1da4ae1
to
13e8560
Compare
13e8560
to
ae9fc20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes to the node-rdkafka example
7517057
to
e9aa0bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an important feature! Thanks Milind
Allow creating admin client from producer or consumer.
For both promisified and non-promisified API.
Also fixes a memory leak in Connection::GetMetadata.