Skip to content

Add dependent admin client #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 20, 2024
Merged

Add dependent admin client #153

merged 8 commits into from
Nov 20, 2024

Conversation

milindl
Copy link
Contributor

@milindl milindl commented Nov 12, 2024

Allow creating admin client from producer or consumer.

For both promisified and non-promisified API.

Also fixes a memory leak in Connection::GetMetadata.

@milindl milindl requested review from a team as code owners November 12, 2024 10:17
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@airlock-confluentinc airlock-confluentinc bot force-pushed the dev_dependent_admin_client branch from 1da4ae1 to 13e8560 Compare November 12, 2024 10:20
@milindl milindl changed the title Add dependant admin client Add dependent admin client Nov 12, 2024
@airlock-confluentinc airlock-confluentinc bot force-pushed the dev_dependent_admin_client branch from 13e8560 to ae9fc20 Compare November 18, 2024 11:45
Copy link
Contributor

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes to the node-rdkafka example

@milindl milindl requested a review from emasab November 18, 2024 14:51
@airlock-confluentinc airlock-confluentinc bot force-pushed the dev_dependent_admin_client branch from 7517057 to e9aa0bd Compare November 19, 2024 09:01
Copy link
Contributor

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an important feature! Thanks Milind

@milindl milindl merged commit 1e4d2cd into master Nov 20, 2024
1 of 2 checks passed
@milindl milindl deleted the dev_dependent_admin_client branch November 20, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants