List offsets api implemented #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
milindl
requested changes
Dec 10, 2024
milindl
reviewed
Dec 11, 2024
milindl
reviewed
Dec 11, 2024
lib/admin.js
Outdated
| * @readonly | ||
| * @memberof RdKafka | ||
| */ | ||
| const IsolationLevel = Object.seal({ |
There was a problem hiding this comment.
Remove the Object.seal (as it's frozen later while exporting)
milindl
approved these changes
Dec 12, 2024
lib/kafkajs/_admin.js
Outdated
| * @param {object} options | ||
| * @param {number?} options.timeout - The request timeout in milliseconds. | ||
| * May be unset (default: 5000) | ||
| * @param {kafkaJS.IsolationLevel?} options.isolationLevel - The isolation level for reading the offsets. |
There was a problem hiding this comment.
Suggested change
| * @param {kafkaJS.IsolationLevel?} options.isolationLevel - The isolation level for reading the offsets. | |
| * @param {KafkaJS.IsolationLevel?} options.isolationLevel - The isolation level for reading the offsets. |
lib/kafkajs/_admin.js
Outdated
| * List offsets for the specified topic partition(s). | ||
| * | ||
| * @param {string} topic - The topic to fetch offsets for. | ||
| * @param {object} options |
There was a problem hiding this comment.
Suggested change
| * @param {object} options | |
| * @param {object?} options |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented list offsets api in name of fetchTopicOffsets for kafkajs and wrote tests and example for it