Skip to content

Node v23 #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Dec 12, 2024
Merged

Node v23 #158

merged 17 commits into from
Dec 12, 2024

Conversation

milindl
Copy link
Contributor

@milindl milindl commented Nov 13, 2024

  1. Update to std=c++20 for node 23. gcc update in semaphore agents for this also.
  2. Updated NAN version.
  3. v8::CopyablePersistentTraits is no longer usable in node 23 because v8 has removed it. https://chromium.googlesource.com/v8/v8/+/c51a81e705d2e407052c6c281214d9d7e209cbab.
    Using Nan::CopyablePersistentTraits causes substitution errors for node 18. However, we can just use Nan::Callback as it wraps the function for us properly.
  4. Semaphore yml now uses job matrix reducing complexity of file by a lot.

Green run (for this green run I changed package.json version to 0.5.0-rc0-dev. I reverted this change before making this PR): https://semaphore.ci.confluent.io/workflows/2bd1ca0f-0d97-4b64-9d56-609ad652c240?pipeline_id=15879558-975b-4759-a151-8ea706f6d9c5

I ran tests manually to confirm.

@milindl milindl requested review from a team as code owners November 13, 2024 16:43
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@@ -95,6 +103,10 @@ blocks:
type: s1-prod-ubuntu20-04-amd64-2
prologue:
commands:
- sudo apt-get update
Copy link
Contributor

@emasab emasab Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we upgrade Ubuntu to 22.04 instead, it should have GCC 11

@milindl
Copy link
Contributor Author

milindl commented Dec 12, 2024

@milindl milindl requested a review from emasab December 12, 2024 03:52
Copy link
Contributor

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@milindl milindl requested a review from emasab December 12, 2024 13:56
@milindl milindl merged commit 6366895 into master Dec 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants