-
Notifications
You must be signed in to change notification settings - Fork 20
Node v23 #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎉 All Contributor License Agreements have been signed. Ready to merge. |
.semaphore/semaphore.yml
Outdated
@@ -95,6 +103,10 @@ blocks: | |||
type: s1-prod-ubuntu20-04-amd64-2 | |||
prologue: | |||
commands: | |||
- sudo apt-get update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we upgrade Ubuntu to 22.04 instead, it should have GCC 11
f0d33c9
to
561f2a7
Compare
Run with successful builds for every OS platform combination: https://semaphore.ci.confluent.io/workflows/07c183ce-cbd5-4a2f-95e6-5fc1bceef206?pipeline_id=58bce03e-17cf-416f-9b82-502b347fd988 |
82f5389
to
6a742db
Compare
6a742db
to
275876f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Using Nan::CopyablePersistentTraits causes substitution errors for node 18. However, we can just use Nan::Callback as it wraps the function for us properly.
Green run (for this green run I changed package.json version to 0.5.0-rc0-dev. I reverted this change before making this PR): https://semaphore.ci.confluent.io/workflows/2bd1ca0f-0d97-4b64-9d56-609ad652c240?pipeline_id=15879558-975b-4759-a151-8ea706f6d9c5
I ran tests manually to confirm.