Add proper errors to promisified admin api #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
emasab
reviewed
Dec 11, 2024
CHANGELOG.md
Outdated
| @@ -7,6 +7,7 @@ v0.5.0 is a limited availability feature release. It is supported for all usage. | |||
|
|
|||
| 1. Add support for an Admin API to delete records.(#141). | |||
| 2. Fixes an issue with unresolved raced Promises leaking in the consumer (#151). | |||
| 3. Add KafkaJS-compatible errors to promisified Admin API (createTopics, deleteGroups, deleteTopicRecords) (#). | |||
emasab
requested changes
Dec 14, 2024
airlock-confluentinc
bot
force-pushed
the
add_proper_errors_to_promisified_admin_api
branch
from
cef9420 to
1997e22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compatibility related changes relating to partial-success or failure cases for createTopics, deleteGroups, and deleteTopicRecords.