Skip to content

Conversation

emasab
Copy link
Contributor

@emasab emasab commented Oct 3, 2025

Please prefix all TypeScript pull-requests with [Typescript]

What

Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required

References

JIRA:

Test & Review

Open questions / Follow-ups

@emasab emasab requested review from a team as code owners October 3, 2025 18:21
@Copilot Copilot AI review requested due to automatic review settings October 3, 2025 18:21
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the confluent-kafka-javascript library to use librdkafka v2.12.0-RC2 and adds an OAuth Azure IMDS (Instance Metadata Service) example for Kafka authentication. The changes demonstrate how to configure OAuth OIDC authentication using Azure managed identity.

  • Updates librdkafka dependency from v2.11.1 to v2.12.0-RC2
  • Adds Azure IMDS OAuth example demonstrating managed identity authentication
  • Updates changelog to document new features and version bump

Reviewed Changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
package.json Updates librdkafka version dependencies to v2.12.0-RC2
lib/error.js Updates generated comment to reflect new librdkafka version
examples/kafkajs/oauthbearer_oidc_azure_imds.js Adds new example showing OAuth OIDC Azure IMDS configuration
deps/librdkafka Updates subproject commit to point to librdkafka v2.12.0-RC2
CHANGELOG.md Documents v1.6.0 release with librdkafka update and Azure IMDS example

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +3 to +4
async function run() {
const bootstrapServers = "";
Copy link

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The empty values in bootstrapServers and azureIMDSQueryParams should include comments explaining what values users need to provide. Consider adding inline comments or a header comment with examples of valid values.

Suggested change
async function run() {
const bootstrapServers = "";
async function run() {
// Specify the Kafka bootstrap servers as a comma-separated list.
// Example: "my-kafka-broker1:9093,my-kafka-broker2:9093"
const bootstrapServers = "";
// Specify Azure IMDS query parameters.
// Example: "api-version=2018-02-01&resource=https://my-resource&client_id=my-client-id"

Copilot uses AI. Check for mistakes.

CHANGELOG.md Outdated

1. References librdkafka v2.12.0. Refer to the [librdkafka v2.12.0 release notes](https://github.com/confluentinc/librdkafka/releases/tag/v2.12.0) for more information.
2. OAuth OIDC method example for Kafka metadata based authentication with
an Azure IMDS endpoint using an attached managed identity as principal (#).
Copy link

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog entry has an incomplete reference '(#)' that should contain the actual issue or PR number.

Suggested change
an Azure IMDS endpoint using an attached managed identity as principal (#).
an Azure IMDS endpoint using an attached managed identity as principal (#321).

Copilot uses AI. Check for mistakes.

@airlock-confluentinc airlock-confluentinc bot force-pushed the dev_kafka_oautbearer_azure_imds branch from 8aadd57 to 5b52e70 Compare October 3, 2025 18:22
@sonarqube-confluent
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (70.90% Estimated after merge)
  • Duplications No duplication information (2.00% Estimated after merge)

Project ID: confluent-kafka-javascript

View in SonarQube

@emasab emasab merged commit e56315c into master Oct 6, 2025
3 checks passed
@emasab emasab deleted the dev_kafka_oautbearer_azure_imds branch October 6, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants