Merkle tree

[vqhuy]

Implement the Merkle prefix tree #2 and STR #3

[masomel]

The field for the cryptographic commitment commit(key || value) should still be included since it needs to be returned as part of the auth path.

[masomel]

Is this wrapper function really needed?

[vqhuy]

No, it will be removed in the refactoring phase.

[masomel]

Same as above, I would put computePrivateIndex in a separate module for all things crypto.

[vqhuy]

I decided to remove db module for the sake of simplicity. Thus, tree/STR storage will be implemented outside this library. All look-up operations now are in-memory only.

[arlolra]

Is this expected to be different from currentNodeUL.index already?

[masomel]

I think at this point it is since the check for equality happens in the if statement above. But as you said in your previous note, the check in that if statement should compare indices, not the keys.

[vqhuy]

Is this expected to be different from currentNodeUL.index already?

No, it should be the same. I removed this redundant code.
cc @masomel

[arlolra]

Ok, I'm going to merge some of this now.

[arlolra]

Let's see if 14956a9 works first though :)

[vqhuy]

This is the travis log of the previous check: https://s3.amazonaws.com/archive.travis-ci.org/jobs/139557242/log.txt (before 14956a9)

Actually Travis did run all subpackage tests

=== RUN TestHistoryHashChain-2
--- PASS: TestHistoryHashChain-2 (0.01s)
=== RUN TestOneEntry-2
--- PASS: TestOneEntry-2 (0.00s)
=== RUN TestTwoEntries-2
--- PASS: TestTwoEntries-2 (0.00s)
=== RUN TestThreeEntries-2
--- PASS: TestThreeEntries-2 (0.00s)
=== RUN TestInsertExistedKey-2
--- PASS: TestInsertExistedKey-2 (0.00s)
=== RUN TestTreeClone-2
--- PASS: TestTreeClone-2 (0.00s)
PASS
ok      github.com/coniks-sys/libmerkleprefixtree-go    0.022s
=== RUN TestSignVerify-2
--- PASS: TestSignVerify-2 (0.00s)
PASS
ok      github.com/coniks-sys/libmerkleprefixtree-go/crypto 0.017s
=== RUN TestBitsBytesConvert-2
--- PASS: TestBitsBytesConvert-2 (0.00s)
PASS
ok      github.com/coniks-sys/libmerkleprefixtree-go/internal   0.002s

So I guess you want to run subpackage tests first?

[arlolra]

Oh, no, I just didn't realize the default for go was go test -v ./...

https://docs.travis-ci.com/user/languages/go#Default-Test-Script

My bad. Sorry for the noise.

[arlolra]

Ok, most of this is merged in 57c9831.

I'll open up a pull with the rest for review.

[arlolra]

Ok, #8 is open for business. Let's talk about the salt there in #9.