Comparator fix #466
Closed
Comparator fix #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking good - thanks! Let's wait for the tests to finish & and I'll try to give it a light review. |
|
I meant to push the last commit to a new branch. Unfortunately it has ended up in this pull request as well ¯_(ツ)_/¯ |
|
Do you want to remove it from this PR? I don't mind if you force push to PR branches (as long as you don't force push to master!). |
|
Yayy! |
|
This also has the flatten inside the s.o. @ChrisJefferson -- you should test with master if you want to play with things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the flattening operation required for .< into the symmetry representation method. Fixing #456