Support grpc-web #2
Labels
enhancement
New feature or request
Comments
|
One more caveat: the protocol document makes it pretty clear that the protocol follows the implementation, rather than the other way around. I can't tell how stable the protocol is, and whether we'll get ourselves into a bad semver situation by implementing it. If we do implement it, I lean towards just putting it in and enabling it by default, like our current Twirp support. Unless there's some broader array of proto-over-HTTP dialects we see ourselves supporting in v1, a plugin system for this seems overly elaborate. |
akshayjshah
added a commit
that referenced
this issue
Feb 3, 2022
Make handlers support gRPC-Web by default, and let users configure clients to use gRPC-Web with an option. This is such a small change from standard gRPC that it's easier to make it a configurable toggle on the gRPC protocol rather than a completely separate protocol. Note that we don't support the application/grpc-web-text family of protocols. They're only necessary for IE10, which even Microsoft doesn't support anymore: any client using the fetch API should use the binary protocol instead. Fixes #2
akshayjshah
added a commit
that referenced
this issue
Feb 3, 2022
Make handlers support gRPC-Web by default, and let users configure clients to use gRPC-Web with an option. This is such a small change from standard gRPC that it's easier to make it a configurable toggle on the gRPC protocol rather than a completely separate protocol. Note that we don't support the application/grpc-web-text family of protocols. They're only necessary for IE10, which even Microsoft doesn't support anymore: any client using the fetch API should use the binary protocol instead. Fixes #2
Merged
akshayjshah
added a commit
that referenced
this issue
Feb 3, 2022
Make handlers support gRPC-Web by default, and let users configure clients to use gRPC-Web with an option. This is such a small change from standard gRPC that it's easier to make it a configurable toggle on the gRPC protocol rather than a completely separate protocol. Note that we don't support the application/grpc-web-text family of protocols. They're only necessary for IE10, which even Microsoft doesn't support anymore: any client using the fetch API should use the binary protocol instead. Fixes #2
akshayjshah
added a commit
that referenced
this issue
Feb 7, 2022
Make handlers support gRPC-Web by default, and let users configure clients to use gRPC-Web with an option. This is such a small change from standard gRPC that it's easier to make it a configurable toggle on the gRPC protocol rather than a completely separate protocol. Note that we don't support the application/grpc-web-text family of protocols. They're only necessary for IE10, which even Microsoft doesn't support anymore: any client using the fetch API should use the binary protocol instead. Fixes #2
akshayjshah
added a commit
that referenced
this issue
Feb 7, 2022
Make handlers support gRPC-Web by default, and let users configure clients to use gRPC-Web with an option. This is such a small change from standard gRPC that it's easier to make it a configurable toggle on the gRPC protocol rather than a completely separate protocol. Note that we don't support the application/grpc-web-text family of protocols. They're only necessary for IE10, which even Microsoft doesn't support anymore: any client using the fetch API should use the binary protocol instead. Fixes #2
akshayjshah
added a commit
that referenced
this issue
Feb 26, 2022
Make handlers support gRPC-Web by default, and let users configure clients to use gRPC-Web with an option. This is such a small change from standard gRPC that it's easier to make it a configurable toggle on the gRPC protocol rather than a completely separate protocol. Note that we don't support the application/grpc-web-text family of protocols. They're only necessary for IE10, which even Microsoft doesn't support anymore: any client using the fetch API should use the binary protocol instead. Fixes #2
akshayjshah
added a commit
that referenced
this issue
Feb 28, 2022
Make handlers support gRPC-Web by default, and let users configure clients to use gRPC-Web with an option. This is such a small change from standard gRPC that it's easier to make it a configurable toggle on the gRPC protocol rather than a completely separate protocol. Note that we don't support the application/grpc-web-text family of protocols. They're only necessary for IE10, which even Microsoft doesn't support anymore: any client using the fetch API should use the binary protocol instead. Fixes #2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should add server-side support for the grpc-web protocol. The protocol itself isn't too different from standard gRPC, and it'd be nice for reRPC servers to directly support web clients.
That said, I'm not sure how much traction grpc-web actually has (i.e., does anyone care about this?). I'm also unsure what our cross-testing options are - would we need to run a headless browser in the reRPC tests?
The text was updated successfully, but these errors were encountered: