-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Schema field to Spec for introspection #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New field Schema of type any on Spec objects. For proto based schemas the type will be of protoreflect.MethodDescriptor. This allows for easy introspection to interceptors.
emcfarlane
commented
Nov 6, 2023
emcfarlane
commented
Nov 6, 2023
jhump
reviewed
Nov 6, 2023
jhump
reviewed
Nov 8, 2023
jhump
reviewed
Nov 8, 2023
jhump
approved these changes
Nov 8, 2023
jhump
reviewed
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New field Schema of type
any
onSpec
. For proto based schemas the type will be ofprotoreflect.MethodDescriptor
. This allows for easy introspection to interceptors.Updated generated code to add the new
WithSchema
option to both handlers and clients. Schema is fetched from the proto file using thefile.GoDescriptorIdent
. To ensure generated code is matched with a library that includes the option a new version tag is added for v1.13.Example
For a unary request one can access the input and output descriptors by casting the interface and using protoreflect:
Fixes #571 and #600