Skip to content

Bump golang and protoc-gen-go #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 27, 2018
Merged

Bump golang and protoc-gen-go #269

merged 3 commits into from
Sep 27, 2018

Conversation

jdef
Copy link
Member

@jdef jdef commented Sep 20, 2018

  • golang v1.10.4
  • protoc-gen-go v1.2.0

@jdef jdef added this to the v0.4 milestone Sep 20, 2018
@jdef jdef requested review from jieyu and saad-ali September 20, 2018 12:09
@jdef
Copy link
Member Author

jdef commented Sep 20, 2018

@jieyu @saad-ali @julian-hj @ddebroy PTAL

ddebroy
ddebroy approved these changes Sep 21, 2018
View reviewed changes
Copy link
Contributor

@ddebroy ddebroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jieyu
jieyu approved these changes Sep 27, 2018
View reviewed changes
Copy link
Member

@jieyu jieyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jdef jdef merged commit 7c6a627 into container-storage-interface:master Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyu jieyu jieyu approved these changes

@saad-ali saad-ali Awaiting requested review from saad-ali

+1 more reviewer

@ddebroy ddebroy ddebroy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@jdef @jieyu @ddebroy