remove container stat dir when no process found in restore #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under some abnormal cases, container state dir exist while pid file not. containerd restore would print this error to log without handling this, it will set container state to stopped without removing its state dir. trying to start the container again will cause error: `mkdir /var/run/docker/libcontainerd/containerd/xxx: file exists` Signed-off-by: Deng Guangxing <dengguangxing@huawei.com>
hqhq
reviewed
May 10, 2017
| @@ -333,8 +333,10 @@ func (s *Supervisor) restore() error { | |||
| continue | |||
| } | |||
| processes, err := container.Processes() | |||
There was a problem hiding this comment.
For now err is always nil, can we ignore it here?
processes, _ := container.Processes()
There was a problem hiding this comment.
keep this error check here will do no harm, but I am happy to remove it because it's not in use. not sure if this error returned is a planned design.
|
LGTM |
1 similar comment
|
LGTM |
This was referenced May 24, 2017
mlaventure
added a commit
to mlaventure/containerd
that referenced
this pull request
Jul 7, 2017
This test that the daemon can restart if it was killed before all a process state dir could be removed. Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
This was referenced Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under some abnormal cases, container state dir exist while pid file not.
containerd restore would print this error to log without handling this,
it will set container state to stopped without removing its state dir.
trying to start the container again will cause error:
mkdir /var/run/docker/libcontainerd/containerd/xxx: file existsSigned-off-by: Deng Guangxing dengguangxing@huawei.com