Add WS2025 to Windows matcher and code optimizations #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
reviewed
Feb 14, 2025
MikeZappa87
approved these changes
Feb 14, 2025
jsturtevant
reviewed
Feb 14, 2025
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
akhilerm
reviewed
May 13, 2025
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
akhilerm
approved these changes
May 13, 2025
mikebrow
reviewed
May 13, 2025
| var compatLTSCReleases = []uint16{ | ||
| v21H2Server, | ||
| ltsc2022, | ||
| ltsc2025, |
There was a problem hiding this comment.
noting that ltsc2019 is not in this set.. pls verify
There was a problem hiding this comment.
Hi @mikebrow yes this is right. ltsc2019 is not stable ABI compliant. This slice just indicates the ones that are.
There was a problem hiding this comment.
Doesnt ABI compliance starts with ltsc2022?
There was a problem hiding this comment.
nod the naming of ltsc2019 made me want to ask :-)
There was a problem hiding this comment.
it's more of a 2019 is no longer ltsc statement
mikebrow
approved these changes
May 13, 2025
Just did. If it looks good, would you be able to merge @mikebrow ? :) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit primarily adds WS2025 to windows matcher and updates test. Similar to what we updated on hcsshim osversion package.