SHA512 digest support #358
The diff you're trying to view is too large. We only load the first 3000 changed files.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,6 +11,7 @@ import ( | |
| "strings" | ||
| "time" | ||
|
|
||
| "github.com/opencontainers/go-digest" | ||
| "github.com/sirupsen/logrus" | ||
| filtersPkg "go.podman.io/common/pkg/filters" | ||
| "go.podman.io/common/pkg/timetype" | ||
|
|
@@ -481,9 +482,45 @@ func filterID(value string) filterFunc { | |
|
|
||
| // filterDigest creates a digest filter for matching the specified value. | ||
| func filterDigest(value string) (filterFunc, error) { | ||
| // Check if it's a valid complete digest | ||
| if _, err := digest.Parse(value); err == nil { | ||
| // Valid complete digest - use it as is | ||
| return func(img *Image, _ *layerTree) (bool, error) { | ||
| return img.containsDigestPrefix(value), nil | ||
| }, nil | ||
| } | ||
|
|
||
| // Not a complete digest - check if it's a valid partial digest with algorithm prefix | ||
| if !strings.Contains(value, ":") { | ||
| return nil, fmt.Errorf("invalid value %q for digest filter: must have algorithm prefix (e.g., sha256:)", value) | ||
| } | ||
|
|
||
| parts := strings.SplitN(value, ":", 2) | ||
| if len(parts) != 2 { | ||
| return nil, fmt.Errorf("invalid value %q for digest filter: invalid format", value) | ||
| } | ||
|
|
||
| algorithm := parts[0] | ||
| hashPart := parts[1] | ||
|
|
||
| // Validate the algorithm is known | ||
| switch algorithm { | ||
| case "sha256", "sha512": // common algorithms | ||
|
There was a problem hiding this comment. (Now that we know digests can be added), this is not maintainable. Either add a (Generally, are other parts of this parser applicable elsewhere? “filters” is not a natural place for “prefix of digest” parser.) |
||
| // Valid algorithm prefix | ||
| default: | ||
| return nil, fmt.Errorf("invalid value %q for digest filter: unsupported algorithm %q", value, algorithm) | ||
| } | ||
|
|
||
| // Validate hash part contains only hex characters | ||
| if len(hashPart) == 0 { | ||
| return nil, fmt.Errorf("invalid value %q for digest filter: empty hash part", value) | ||
| } | ||
| for _, c := range hashPart { | ||
| if (c < '0' || c > '9') && (c < 'a' || c > 'f') && (c < 'A' || c > 'F') { | ||
| return nil, fmt.Errorf("invalid value %q for digest filter: hash part contains non-hex characters", value) | ||
| } | ||
| } | ||
|
|
||
| return func(img *Image, _ *layerTree) (bool, error) { | ||
| return img.containsDigestPrefix(value), nil | ||
| }, nil | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A generic design question: What happens / what do we want to happen if the on-registry image is digest A, c/storage configuration is digest B, and the user filters using digest C - or some subset of that?
What is the goal of this PR?