Cleanup copr targets for packit, manage bats and golang deps idiomatically on TMT

[lsm5]

Summary by Sourcery

Update the .packit.yaml configuration to streamline directory creation and consolidate Fedora targets. Remove redundant dependency installation from the podman-tests.sh script.

Build:

• Update the .packit.yaml configuration to include 'mkpath: true' for certain directories, ensuring they are created if they do not exist.

CI:

• Modify the .packit.yaml configuration to consolidate Fedora targets into a single 'fedora-all' target for copr builds.

Tests:

• Remove the installation of test dependencies 'bats' and 'golang' from the podman-tests.sh script, assuming they are available in the testing environment.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR updates the package configuration and test files to handle end-of-life (EOL) changes. The main changes include simplifying Fedora targets in the Copr build configuration, updating file sync settings with mkpath options, and removing explicit package installation commands from the test script.

Class diagram for updated file sync settings in .packit.yaml

classDiagram
    class FileSync {
        - src: String
        - dest: String
        - delete: Boolean
        + mkpath: Boolean
    }
    FileSync : +mkpath = true
    note for FileSync "mkpath option added to file sync settings"

Loading

Class diagram for test script changes

classDiagram
    class TestScript {
        - InstallDependencies()
        + PrintVersions()
    }
    TestScript : -InstallDependencies() // Removed
    TestScript : +PrintVersions() // Remains unchanged
    note for TestScript "Removed explicit package installation commands"

Loading

File-Level Changes

Change	Details	Files
Simplified Fedora targets configuration in Copr builds	Replaced multiple specific Fedora version targets with a single 'fedora-all' target Removed individual targets for development, latest, and test-stable versions	.packit.yaml
Enhanced file synchronization configuration	Added mkpath: true option for plans/ directory sync Added mkpath: true option for test/ directory sync	.packit.yaml
Streamlined test environment setup	Removed explicit dnf installation of bats and golang packages Retained version checking of installed packages	test/podman-tests.sh
Updated FMF test plan structure	Renamed plans/all.fmf to plans/main.fmf Modified test/main.fmf configuration	plans/all.fmf plans/main.fmf test/main.fmf

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @lsm5 - I've reviewed your changes - here's some feedback:

Overall Comments:

• The removal of explicit dependency installation (bats, golang) from podman-tests.sh needs clarification. Are these dependencies now handled elsewhere in the build/test pipeline?

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[lsm5]

This will have to wait until dnf metadata issues are resolved on c10s. Reported to the maintainers already.

[rhatdan]

LGTM