Skip to content

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Dec 26, 2024

dnf download on CentOS Stream ends up downloading all rpm versions of a package from all available repos instead of only the latest rpm. This leads to more (unnecessary) complications in the test script.

Things are a lot simpler if we directly test using the podman-tests package. This means we'll have to disable podman e2e tests and only do system tests but that shouldn't be too big a problem.

A better way to run podman e2e tests would be by creating a podman-src rpm subpackage that'll install all the rpm sources.

Summary by Sourcery

Tests:

  • Simplified the podman test script by switching from e2e tests to system tests.

`dnf download` on CentOS Stream ends up downloading all rpm versions of
a package from all available repos instead of only the latest rpm. This
leads to more (unnecessary) complications in the test script.

Things are a lot simpler if we directly test using the `podman-tests`
package. This means we'll have to disable podman e2e tests and only do
system tests but that shouldn't be too big a problem.

A better way to run podman e2e tests would be by creating a `podman-src`
rpm subpackage that'll install all the rpm sources.

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
Copy link

sourcery-ai bot commented Dec 26, 2024

Reviewer's Guide by Sourcery

Simplified the podman test script by directly using the podman-tests package for system tests and removing the e2e tests. A potential enhancement for e2e tests involves creating a podman-src rpm subpackage.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Removed e2e tests and simplified the test script to use the installed podman-tests package.
  • Removed the logic for fetching and extracting the latest podman source.
  • Removed the conditional execution of e2e and system tests based on the TEST_TYPE argument.
  • Removed the code that checks for matching versions of podman-tests and podman SRPM.
  • Simplified the script to directly run podman system tests using bats.
test/podman-tests.sh
Removed the usage of the TEST_TYPE argument.
  • Removed the code that checks for the TEST_TYPE argument and prints usage instructions.
  • Removed the conditional execution of tests based on the TEST_TYPE argument.
test/podman-tests.sh
test/main.fmf

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@lsm5
Copy link
Member Author

lsm5 commented Dec 26, 2024

handled in #345

@lsm5 lsm5 closed this Dec 26, 2024
@lsm5 lsm5 deleted the tmt-simplify-tests branch February 20, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant