-
Notifications
You must be signed in to change notification settings - Fork 106
container_log{reader,writer}_t: allow watch file #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request modifies container.te to allow the container to watch files. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @haircommander - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please provide a complete description of the changes including:
- The specific problem being solved
- Why the current policy is insufficient
- What new capabilities are being granted
- Analysis of potential security implications
Additionally, ensure the PR includes the complete diff of the changes.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Ephemeral COPR build failed. @containers/packit-build please check. |
LGTM |
Signed-off-by: Peter Hunt <pehunt@redhat.com>
86ca8f3
to
16a50b2
Compare
@haircommander I guess you'd want this backported to I'm also in the middle of enabling mergebot here so we can cherrypick easily. |
yes please! /cherry-pick rhaos-maint |
middle, not the end it seems :) |
just going for it manually #354 |
context: https://issues.redhat.com/browse/OCPBUGS-48555
Summary by Sourcery
Bug Fixes: