Skip to content

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Feb 6, 2025

Need this to enable openshift mergebot.

Summary by Sourcery

Chores:

  • Introduce an OWNERS file to enable the Openshift mergebot.

Need this to enable openshift mergebot.

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
Copy link

sourcery-ai bot commented Feb 6, 2025

Reviewer's Guide by Sourcery

This pull request adds the OWNERS file to the repository. This is necessary to enable the openshift mergebot.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added OWNERS file.
  • Added the OWNERS file
OWNERS

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lsm5 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@lsm5
Copy link
Member Author

lsm5 commented Feb 6, 2025

@haircommander @rhatdan PTAL . Let me know if anyone else should be on this file already.

@haircommander
Copy link
Collaborator

I don't really know if I'm qualified but I'll accept the honor if y'all deem me as such

@lsm5 lsm5 merged commit bf26c8d into containers:main Feb 7, 2025
28 checks passed
@lsm5 lsm5 deleted the add-owners branch February 7, 2025 10:29
@rhatdan
Copy link
Member

rhatdan commented Feb 10, 2025

We should probably add someone from the Red Hat SELinux team as well.

@lsm5
Copy link
Member Author

lsm5 commented Feb 11, 2025

We should probably add someone from the Red Hat SELinux team as well.

@rhatdan any suggestions?

@rhatdan
Copy link
Member

rhatdan commented Feb 11, 2025

@wrabcak WDYT?

@wrabcak
Copy link
Member

wrabcak commented Feb 11, 2025

Yes, please put my nickname and also @zpytela, what do you think, can we add you as owner of container-selinux repo ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants