-
Notifications
You must be signed in to change notification settings - Fork 106
OWNERS: add wrabcak and zpytela #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
Reviewer's Guide by SourceryThis pull request adds two new reviewers, wrabcak and zpytela, to the OWNERS file. The changes are implemented by simply appending the new entries in the file. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lsm5 - I've reviewed your changes - here's some feedback:
Overall Comments:
- It would be helpful to include the GitHub usernames of the new owners in the OWNERS file.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
LGTM |
@zpytela haven't received an ack from you yet, so do let me know if you prefer not to be on here ✌️ |
I expect @zpytela will answer after 02/17. |
/cherrypick rhaos-maint |
@rhatdan @haircommander @wrabcak @zpytela PTAL
Summary by Sourcery
Chores: