Skip to content

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Feb 11, 2025

@rhatdan @haircommander @wrabcak @zpytela PTAL

Summary by Sourcery

Chores:

  • Update the OWNERS file.

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
Copy link

sourcery-ai bot commented Feb 11, 2025

Reviewer's Guide by Sourcery

This pull request adds two new reviewers, wrabcak and zpytela, to the OWNERS file. The changes are implemented by simply appending the new entries in the file.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added new owner entries. OWNERS

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lsm5 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • It would be helpful to include the GitHub usernames of the new owners in the OWNERS file.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rhatdan
Copy link
Member

rhatdan commented Feb 11, 2025

LGTM

@rhatdan rhatdan merged commit 5a26485 into containers:main Feb 11, 2025
28 checks passed
@lsm5
Copy link
Member Author

lsm5 commented Feb 13, 2025

@zpytela haven't received an ack from you yet, so do let me know if you prefer not to be on here ✌️

@wrabcak
Copy link
Member

wrabcak commented Feb 13, 2025

I expect @zpytela will answer after 02/17.

@lsm5
Copy link
Member Author

lsm5 commented Feb 19, 2025

/cherrypick rhaos-maint

@lsm5 lsm5 deleted the selinux-owners branch February 19, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants