-
Notifications
You must be signed in to change notification settings - Fork 106
Bump to v2.235.0 #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to v2.235.0 #358
Conversation
Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lsm5 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
/lgtm |
@haircommander: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Weird why that happened. Looking into this. |
Looks like OWNERS needs a reviewer section. Adding it in another PR. |
The OWNERS file in mergebot only got updated about 3 hours ago. So, I guess a slash-lgtm should work with a retry. The OWNERS file shouldn't need any changes. |
/lgtm 👀 |
@haircommander: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I wonder if i'm in the org... |
I do see |
@haircommander I added you to the Collaborator list just now. Try again please. |
/lgtm |
/cherrypick rhaos-maint |
/cherrypick rhaos-maint |
@lsm5: new pull request created: #362 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
It's been over 3 months since the last release and there's been at least a couple of changes that users would be looking for.
@haircommander @rhatdan @wrabcak PTAL
Summary by Sourcery
Chores: