-
Notifications
You must be signed in to change notification settings - Fork 106
[rhaos-maint] add container_ro_file_t to the podman artifact store #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rhaos-maint] add container_ro_file_t to the podman artifact store #363
Conversation
Reviewer's Guide by SourceryThis pull request adds the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @openshift-cherrypick-robot - I've reviewed your changes - here's some feedback:
Overall Comments:
- Since this is an automated cherry-pick, double-check that the changes apply cleanly and that there are no unexpected conflicts or regressions.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The artifact store contains many blobs which we like to get mounted into the container. However by default selinux prevents access to these files. Now I could patch podman to change the label directly but it seems like much better to just label the entire artifact store correctly like we do with the image store. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
d190193
to
85dfa7e
Compare
New changes are detected. LGTM label has been removed. |
LGTM |
This is an automated cherry-pick of #360
/assign lsm5
Summary by Sourcery
Adds container_ro_file_t to the podman artifact store.