Skip to content

Conversation

openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Feb 27, 2025

This is an automated cherry-pick of #360

/assign lsm5

Summary by Sourcery

Adds container_ro_file_t to the podman artifact store.

Copy link

sourcery-ai bot commented Feb 27, 2025

Reviewer's Guide by Sourcery

This pull request adds the container_ro_file_t type to the podman artifact store. This change involves modifications to container.fc and container.if to incorporate the new file type.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added container_ro_file_t type to the podman artifact store.
  • Added a new file type container_ro_file_t.
  • Modified the policy to include the new file type.
container.fc
container.if

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @openshift-cherrypick-robot - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Since this is an automated cherry-pick, double-check that the changes apply cleanly and that there are no unexpected conflicts or regressions.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 27, 2025
Copy link

openshift-ci bot commented Feb 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

The artifact store contains many blobs which we like to get mounted into
the container. However by default selinux prevents access to these
files. Now I could patch podman to change the label directly but it
seems like much better to just label the entire artifact store correctly
like we do with the image store.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@lsm5 lsm5 force-pushed the cherry-pick-360-to-rhaos-maint branch from d190193 to 85dfa7e Compare February 27, 2025 15:54
@openshift-ci openshift-ci bot removed the lgtm label Feb 27, 2025
Copy link

openshift-ci bot commented Feb 27, 2025

New changes are detected. LGTM label has been removed.

@rhatdan
Copy link
Member

rhatdan commented Feb 27, 2025

LGTM

@rhatdan rhatdan merged commit 98b17f3 into containers:rhaos-maint Feb 27, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants