Skip to content

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Aug 29, 2025

ELN composes are now available in testing-farm. This enables way-too-early testing for the next RHEL.

Summary by Sourcery

Enable early testing on the next RHEL by adding a new TMT tests job for Fedora ELN and factoring ELN Copr build targets into a shared anchor in .packit.yaml

Enhancements:

  • Add testing-farm TMT job for Fedora ELN compose in .packit.yaml
  • Extract and reuse ELN Copr build targets with a YAML anchor

Copy link

sourcery-ai bot commented Aug 29, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR configures packit to support Fedora ELN composes by extracting ELN-specific build targets into a reusable YAML anchor, updating the existing Copr build job to use that anchor, and adding a new pull_request-triggered Testing Farm tests job with the appropriate ELN repository-file artifact.

Entity relationship diagram for ELN Copr targets reuse

erDiagram
    JOBS {
        string job_type
        string trigger
        string packages
        string notifications
        string targets
        string tf_extra_params
    }
    ELN_COPR_TARGETS {
        string fedora_eln_x86_64
        string fedora_eln_aarch64
    }
    JOBS ||--o{ ELN_COPR_TARGETS : uses
    ELN_COPR_TARGETS {
        string anchor_name
    }
Loading

Class diagram for updated Packit job configuration (.packit.yaml)

classDiagram
    class Jobs {
        +copr_build
        +tests_fedora_eln
        +tests_centos_stream
    }
    class CoprBuild {
        +packages
        +notifications
        +enable_net
        +targets
    }
    class TestsFedoraELN {
        +trigger
        +packages
        +notifications
        +targets
        +tf_extra_params
    }
    class ELNCoprTargets {
        +fedora-eln-x86_64
        +fedora-eln-aarch64
    }
    Jobs --> CoprBuild : copr_build
    Jobs --> TestsFedoraELN : tests_fedora_eln
    CoprBuild --> ELNCoprTargets : uses targets
    TestsFedoraELN --> ELNCoprTargets : uses targets
    class TestsCentOSStream {
        +trigger
        +packages
        +notifications
        +targets
        +tf_extra_params
    }
    Jobs --> TestsCentOSStream : tests_centos_stream
Loading

File-Level Changes

Change Details Files
Introduce reusable eln_copr_targets anchor for ELN build targets
  • Define &eln_copr_targets anchor with fedora-eln-x86_64 and fedora-eln-aarch64 targets
.packit.yaml
Update existing Copr build job to reference the new ELN targets anchor
  • Replace inline ELN targets list with *eln_copr_targets reference
.packit.yaml
Add a pull_request-triggered Testing Farm tests job for Fedora ELN
  • Add new tests job block with trigger: pull_request
  • Reuse *eln_copr_targets for the targets field
  • Configure tf_extra_params to include the ELN repository-file artifact
.packit.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

ELN composes are now available in testing-farm. This enables
way-too-early testing for the next RHEL.

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
Copy link
Member Author

lsm5 commented Sep 1, 2025

/packit retest-failed

@lsm5 lsm5 marked this pull request as ready for review September 3, 2025 19:35
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

openshift-ci bot commented Sep 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, sourcery-ai[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Sep 4, 2025

LGTM

@rhatdan rhatdan merged commit 114dc58 into containers:main Sep 4, 2025
30 of 31 checks passed
@lsm5 lsm5 deleted the tmt-eln branch September 4, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants