selinux: fix containers access for shared runtime directories

[sohankunkerkar]

Summary by Sourcery

Update SELinux policy to allow container processes to access shared runtime directories, fixing permission denials on mounted host directories

Bug Fixes:

• Allow container domains to access shared host runtime directories under /run, correcting access denials

Enhancements:

• Define new SELinux types for shared runtime paths and add rules granting necessary read, write, and search permissions

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This patch extends the SELinux container policy to label and permit access to shared runtime directories (e.g. /run/containers, /run/docker) by updating file contexts, defining a new type, and adding the necessary allow rules in the container domain.

File-Level Changes

Change	Details	Files
Define and label a new SELinux type for shared container runtime dirs	Introduce container_runtime_share_dir_t type Update file_contexts to assign label to /run/containers and /run/docker Add matching entries in container.fc	container.fc file_contexts
Grant container_t permission to manage the new shared runtime type	Add allow rules for container_t to {search read write} the share dir type Permit container_t to create and unlink files within those dirs Include the new type in the container_runtime_exec_t macro	container.te
Update policy macros to include shared runtime dirs	Extend container_file_access macro to cover container_runtime_share_dir_t Ensure existing tests reference the new type Bump module version and regenerate policy module build	container.te Makefile

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[gemini-code-assist]

Summary of Changes

Hello @sohankunkerkar, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an SELinux policy adjustment to correctly manage container access to shared runtime directories. The change ensures that containers have the necessary permissions to interact with these directories while maintaining a principle of least privilege, enhancing overall system security.

Highlights

• SELinux Policy Refinement: The SELinux policy for containers accessing shared runtime directories has been updated. The permission set for container_t on container_var_run_t:dir was changed from read open to list_dir_perms to provide more precise access control.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[gemini-code-assist]

Code Review

This pull request correctly fixes container access to shared runtime directories by replacing the overly restrictive { read open } permissions with the list_dir_perms macro. This change grants the necessary permissions for OCI runtimes to inspect these directories, such as search and getattr, while still preventing any modifications. The use of a standard macro is a good practice, and the change improves functionality without introducing security risks. The fix is sound and well-implemented.

[sohankunkerkar]

@rhatdan @giuseppe @lsm5 PTAL

[giuseppe]

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: giuseppe, sohankunkerkar, sourcery-ai[bot]
Once this PR has been reviewed and has the lgtm label, please assign lsm5 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

LGTM

[lsm5]

@sohankunkerkar thanks. Were you able to test the fix prior to merge? Also, any recommendations on adding ocp tests to container-selinux?

[sohankunkerkar]

@lsm5 Yup, I have already commented here-> #396 (comment)

Also, any recommendations on adding ocp tests to container-selinux?

I think you need to set up prow for this repo in openshift/release to leverage openshift test-suite.

[lsm5]

I think you need to set up prow for this repo in openshift/release to leverage openshift test-suite.

@sohankunkerkar would you have time to do it for this repo? If not, mind giving us a handy link / doc ?

[lsm5]

/cherrypick rhaos-maint

[openshift-cherrypick-robot]

@lsm5: new pull request created: #400

In response to this:

/cherrypick rhaos-maint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.