add ability to opt-in to validate git signature created w/ sigstore/gitsign #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sallyom
force-pushed
the
gitsign
branch
3 times, most recently
from
e6b38e4
to
3998ed5
Compare
Closed
sallyom
force-pushed
the
gitsign
branch
2 times, most recently
from
f59d534
to
e60092f
Compare
Signed-off-by: Sally O'Malley <somalley@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cooktheryan @josephsawaya
resolves #212
Adds an opt-in function for validating gitsign-ed commits. The bet is that gitsign will catch on and more gitOps workflows will request verified/signed commits.
(Also in this PR, I limited the len of commit hash printing in logs to 9 chars, I think it looks better, but we have a lot of work to do to make pretty logs so if it makes sense to leave it be for now that's fine, too.)