Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test against skopeo? #13

Closed
mtrmac opened this issue Jun 27, 2016 · 1 comment
Closed

Add a test against skopeo? #13

mtrmac opened this issue Jun 27, 2016 · 1 comment
Labels
kind/feature A request for, or a PR adding, new functionality

Comments

@mtrmac
Copy link
Collaborator

mtrmac commented Jun 27, 2016

So here is a completely horrible idea: As part of tests, perhaps in Makefile and definitely in Travis, checkout skopeo, replace the vendored copy with current working directory, and test that skopeo runs and its tests pass.

As I said, completely horrible. But perhaps worth it, at least until most of the transports in this repo grow some real tests. Merging containers/skopeo#102 and only a week later discovering that it breaks pushing to OpenShift would be pretty awkward…

WDY(all)T?

@runcom
Copy link
Member

runcom commented Jun 28, 2016

seems fine to me as a temporary workaround until we figure the whole stuff out and given skopeo is the reference implementation for this library now

@runcom runcom added the kind/feature A request for, or a PR adding, new functionality label Jun 29, 2016
@runcom runcom closed this as completed in #27 Jul 4, 2016
rchincha pushed a commit to rchincha/image that referenced this issue Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A request for, or a PR adding, new functionality
Projects
None yet
Development

No branches or pull requests

2 participants