[RFC Do not merge] Add copy.Options.LayerSubset. #159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
makes sense |
|
I don't think we're in any hurry here. We're not going to drop |
mtrmac
force-pushed
the
copy-layers-list
branch
4 times, most recently
from
cfd4ced
to
18a5bb0
Compare
mtrmac
force-pushed
the
copy-layers-list
branch
4 times, most recently
from
72c8357
to
9a9b5c0
Compare
mtrmac
force-pushed
the
copy-layers-list
branch
3 times, most recently
from
67562aa
to
cd286a2
Compare
This was referenced Jan 17, 2017
Closed
mtrmac
force-pushed
the
copy-layers-list
branch
from
cd286a2
to
e2e7f4a
Compare
giuseppe
pushed a commit
to giuseppe/image
that referenced
this pull request
Jan 24, 2017
minor cleanup for build issues related to the manual
mtrmac
force-pushed
the
copy-layers-list
branch
5 times, most recently
from
474edbb
to
f13f317
Compare
mtrmac
force-pushed
the
copy-layers-list
branch
from
f13f317
to
4ea0bd0
Compare
mtrmac
force-pushed
the
copy-layers-list
branch
from
4ea0bd0
to
41e7d62
Compare
mtrmac
force-pushed
the
copy-layers-list
branch
3 times, most recently
from
e0217d4
to
d417b74
Compare
mtrmac
force-pushed
the
copy-layers-list
branch
from
ce2bfc9
to
af7d73c
Compare
mtrmac
force-pushed
the
copy-layers-list
branch
5 times, most recently
from
49801ba
to
f39accd
Compare
mtrmac
force-pushed
the
copy-layers-list
branch
2 times, most recently
from
93dd34f
to
1f2c899
Compare
mtrmac
force-pushed
the
copy-layers-list
branch
from
1f2c899
to
45fdb13
Compare
|
This should no longer be necessary with #228. Can I close this PR, or am I missing anything? |
FIXME: Should come with more warnings. This is needed to allow the Python code in atomic to only download the subset of layers which is not already available locally, while still verifying signatures and validating layer digests (per discussion in containers/skopeo#242 ). Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
force-pushed
the
copy-layers-list
branch
from
45fdb13
to
fb58783
Compare
|
Assuming this is superseded by #228 , closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now just to get an idea of what this would take…
FIXME: Should come with more warnings.
This is needed to allow the Python code in atomic to only download the subset of layers which is not already available locally, while still verifying signatures and validating layer digests (per discussion in
containers/skopeo#242 ).