Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove go-conections uses in tlsclientconfig #1748

Merged
merged 2 commits into from
Dec 9, 2022

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Dec 8, 2022

A small cleanup that should not affect behavior; see individual commit messages for details.

Motivated by #161 .

Note that this does not change anything about the TLS configuration, or express any opinions about the HTTP configuration. Also, the dependency is still used indirectly due to other subpackages.

tlsconfig.SystemCertPool only special-cases handling a failure of
x509.SystemCertPool on Windows; but nowadays, Go has a special implementation
of the "system" pool, and loading the Windows one can never fail.

So, whatever this was originally supposed to do, it isn't necessary any more.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
sockets.DialerFromEnvironment seems to implement an all_proxy
environment variable.

Either way, since containers#731 the
return value was ignored, making that code completely ineffective,
and noone has complained for three years.

So let's just drop it.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Dec 9, 2022

LGTM

@rhatdan rhatdan merged commit 1ed666a into containers:main Dec 9, 2022
@mtrmac mtrmac deleted the tlsconfig branch December 9, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants