Beautify #2467
Merged
Beautify #2467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve |
mtrmac
force-pushed
the
eautify
branch
3 times, most recently
from
1c81438
to
597d314
Compare
The compiler is smart enough that referencing a local variable is not any faster than len(srcInfos). If anything, keeping the extra variable might add to register pressure because the compiler might not understand that the srcInfos change due to LayerInfosForCopy does not change the number of layers. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Otherwise "err" refers to a variable outside of this closure, not even to the one used by the immediate caller. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some parts come from #1147, some are just vaguely related.
Should not change behavior.
See individual commit messages for details.