Preserve more-recently-added fields when copying/updating OCI indices #2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No non-test code changes, should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
We will add more callers soon. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
... so that it does not discard the recently-added fields. Also add unit tests. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
@AlbanBedel This fixes the reproducer from #2460 from me; an independent verification would be appreciated. |
mtrmac
added
the
kind/bug
|
LGTM |
|
Works fine with my test case. |
|
Thanks for the confirmation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that, e.g.,
skopeo copydoes not drop theartifactTypefield.Also adds unit tests.
Fixes #2460 .