feat: add "disabled" mutli cluster strategy #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
matzew
reviewed
Oct 7, 2025
| ) | ||
|
|
||
| const ( | ||
| flagVersion = "version" |
There was a problem hiding this comment.
these are nice, but I'd have perhaps done this in a separate PR before. Like a "pre factoring".
But since the change is small, this is adding not too much noise. Just as a general statement
matzew
reviewed
Oct 7, 2025
|
|
||
| strategy := m.StaticConfig.ClusterProviderStrategy | ||
| if strategy == "" { | ||
| strategy = "auto-detect (it is advisable to set this explicitly in your Config)" |
There was a problem hiding this comment.
IMO this should be at most recommended.
manusa
approved these changes
Oct 7, 2025
…advisable Signed-off-by: Calum Murray <cmurray@redhat.com>
Cali0707
force-pushed
the
disabled-multi-cluster-strategy
branch
from
823d46c to
df0fe04
Compare
|
LGTM thanks for changing to recommended! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #348 to allow for a "disabled" strategy, as well as a command line flag for disabling the multi cluster support.
To disable multi-cluster, users can start the server with:
Relates to #83