Fix concurrency issues on Apple Silicon #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Apple Silicon, we were hitting a concurrency error that manifest with recv() panicking like this: thread '<unnamed>' panicked at 'internal error: entered unreachable code' Seems to be a known issue rust-lang/rust#39364 Follow the recommendation on the thread, and switch from mpsc (which seems its going to be retired) to crossbeam-channel. Signed-off-by: Sergio Lopez <slp@sinrega.org>
We need an acquire fence before reading next descriptor index to make sure we catch the latest updates on the queue. This bug seems to be only reproducible on Apple Silicon (I've tried other 3 AArch64 machines, without success), most likely due to it's very large ROB. Fixes: containers/krunvm#12 Signed-off-by: Sergio Lopez <slp@sinrega.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.