Respect the quiet flag. #23
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting the `kpod load -q` flag, output was still going to the screen. This patch adds a check to not output to the terminal unless there is an io.Writer specified, and then to write to the io.Writer. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
oops, I should have caught this :/ LGTM |
|
📌 Commit ce5ed34 has been approved by |
|
⚡ Test exempted: pull fully rebased and already tested. |
baude
referenced
this pull request
in baude/podman
Aug 31, 2019
openshift-merge-robot
pushed a commit
that referenced
this pull request
Nov 26, 2019
Improve error handling
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting the
kpod load -qflag, output was still going to thescreen. This patch adds a check to not output to the terminal unless
there is an io.Writer specified, and then to write to the io.Writer.
Signed-off-by: Daniel J Walsh dwalsh@redhat.com