Skip to content

Conversation

SuNNjek
Copy link
Contributor

@SuNNjek SuNNjek commented Apr 24, 2025

Does this PR introduce a user-facing change?

Yes

Quadlet Pod - add support for Label key

Fixes #25961

@SuNNjek SuNNjek changed the title Quadlet pod labels Add Label to quadlet pod Apr 24, 2025
@SuNNjek SuNNjek force-pushed the quadlet-pod-labels branch from 6393c72 to 7eecf47 Compare April 24, 2025 12:05
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, code wise looks good but please squash your commits into one. We generally prefer code/docs and tests in one commit.

cc @ygalblum

Copy link
Contributor

@ygalblum ygalblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM for the code. Just please squash all commits together.

Signed-off-by: Robin Heinemeier <sunnerlp@gmail.com>
@SuNNjek SuNNjek force-pushed the quadlet-pod-labels branch from 7eecf47 to 802fc15 Compare April 24, 2025 13:38
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2025
Copy link
Contributor

openshift-ci bot commented Apr 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, SuNNjek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2025
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-merge-bot openshift-merge-bot bot merged commit 2b647bf into containers:main Apr 24, 2025
73 checks passed
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jul 24, 2025
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Jul 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Quadlet] unsupported key 'Label'
4 participants