A couple of minor stats improvements for FreeBSD #27105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
markjdb
commented
Sep 18, 2025
markjdb
commented
Include an explicit container state check. Otherwise the containers/stats endpoint will return all-zero stats for a stopped container even when in non-streaming mode, which breaks some consumers of the API, particularly nomad's podman driver. Implement the interface by just returning the number of host CPUs. A bit more sophisticated would be to fetch the jail's cpuset, but it's not very important for now. Signed-off-by: Mark Johnston <mark.johnston@klarasystems.com>
github-actions
bot
added
the
kind/api-change
Signed-off-by: Mark Johnston <mark.johnston@klarasystems.com>
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
|
Adding no new tests because we don't presently have a FreeBSD suite beyond basic compile testing |
|
/approve |
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, markjdb, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Looks good to me |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.