Skip to content

test: remove skip_if_remote from podman run - uidmapping has no /sys/kernel mounts #27136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2025
Merged

test: remove skip_if_remote from podman run - uidmapping has no /sys/kernel mounts #27136

merged 1 commit into from
Sep 24, 2025

Conversation

nimdrak
Copy link
Contributor

@nimdrak nimdrak commented Sep 22, 2025 •
edited
Loading

Fixed #27117

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Sep 22, 2025
@nimdrak
test: remove skip_if_remote from podman run - uidmapping has no /sys/…
51f4e61 
…kernel mounts

Fixes: containers#27117

Signed-off-by: ByoungUk Lee <nimdrak@gmail.com>
@packit-as-a-service Packit-as-a-Service
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

2 similar comments
@packit-as-a-service Packit-as-a-Service
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@packit-as-a-service Packit-as-a-Service
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@nimdrak nimdrak changed the title test: remove skip_if_remote from podman run - uidmapping has no /sys/kernel mounts [WIP] test: remove skip_if_remote from podman run - uidmapping has no /sys/kernel mounts Sep 22, 2025
@nimdrak nimdrak marked this pull request as draft September 22, 2025 04:58
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2025
lsm5
lsm5 approved these changes Sep 22, 2025
View reviewed changes
Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@containers/podman-maintainers PTAL

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2025
@lsm5 lsm5 removed approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Sep 22, 2025
@lsm5
Copy link
Member

lsm5 commented Sep 22, 2025

@nimdrak still needed to be draft?

@nimdrak
Copy link
Contributor Author

nimdrak commented Sep 22, 2025

@lsm5 Yes, I will finish it soon. Thanks!

@nimdrak nimdrak marked this pull request as ready for review September 23, 2025 13:17
@nimdrak
Copy link
Contributor Author

nimdrak commented Sep 23, 2025

@lsm5 Thanks for reviewing this!

@nimdrak nimdrak changed the title [WIP] test: remove skip_if_remote from podman run - uidmapping has no /sys/kernel mounts test: remove skip_if_remote from podman run - uidmapping has no /sys/kernel mounts Sep 23, 2025
@openshift-ci openshift-ci bot added do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 23, 2025
@nimdrak
Copy link
Contributor Author

nimdrak commented Sep 23, 2025

/assign

@nimdrak
Copy link
Contributor Author

nimdrak commented Sep 23, 2025 •
edited
Loading

I think this PR don't need to have the label do-not-merge/release-note-label-needed because the changes is only about tests.

@openshift-ci openshift-ci bot added release-note-none and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Sep 23, 2025
@mheon
Copy link
Member

mheon commented Sep 23, 2025

Fixed your release note block, should work now

@mheon
Copy link
Member

mheon commented Sep 23, 2025

/approve
LGTM

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2025
@nimdrak
Copy link
Contributor Author

nimdrak commented Sep 23, 2025

@mheon Thanks!

Honny1
Honny1 approved these changes Sep 24, 2025
View reviewed changes
Copy link
Member

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Honny1, lsm5, mheon, nimdrak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b223d14 into containers:main Sep 24, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsm5 lsm5 lsm5 approved these changes

+1 more reviewer

@Honny1 Honny1 Honny1 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@nimdrak nimdrak

@Honny1 Honny1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test: remove skip_if_remote from podman run - uidmapping has no /sys/kernel mounts
4 participants
@nimdrak @lsm5 @mheon @Honny1