Skip to content

Conversation

arsenalzp
Copy link
Contributor

@arsenalzp arsenalzp commented Sep 27, 2025

Hello,
This PR is solving the issue #26769.
I decided to introduce this PR as draft one, because the issue doesn't have solid decision on publish port behavior.
The code introduces a new option --multiple-pods, which allows users to create multiple Pods (Deployment.spec.replicas > 1) and it changes --publish option behavior as user has to set

So, the idea is to use as many publishing ports as many Replicas is created, therefore it is user's responsibility on which ports are used on host side; no need to take random ports as those port might be blocked on firewalls, etc.
For example, if Replicas = 2 then it is necessary to use option--publish with 8080:80,8081:80 value.

Once final decision on this solution is approved then I will update Docs and crate tests

Does this PR introduce a user-facing change?

No


Signed-off-by: Oleksandr Krutko <alexander.krutko@gmail.com>
Signed-off-by: Oleksandr Krutko <alexander.krutko@gmail.com>
Copy link
Contributor

openshift-ci bot commented Sep 27, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Sep 27, 2025
Copy link
Contributor

openshift-ci bot commented Sep 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arsenalzp
Once this PR has been reviewed and has the lgtm label, please assign giuseppe for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Oleksandr Krutko <alexander.krutko@gmail.com>
@TomSweeneyRedHat
Copy link
Member

@arsenalzp good start on this, TYVM!

I agree with @flouthoc 's comments, and we'll need some tests added before we can merge this.

@TomSweeneyRedHat
Copy link
Member

And you'll need to tweak the man pages a bit per the CI:

hack/man-page-checker
hack/xref-helpmsgs-manpages
xref-helpmsgs-manpages: 'podman kube play --help' lists '--multiple-pods', which is not in docs/source/markdown/podman-kube-play.1.md
make: *** [Makefile:608: xref-helpmsgs-manpages] Error 1

@arsenalzp
Copy link
Contributor Author

And you'll need to tweak the man pages a bit per the CI:

hack/man-page-checker
hack/xref-helpmsgs-manpages
xref-helpmsgs-manpages: 'podman kube play --help' lists '--multiple-pods', which is not in docs/source/markdown/podman-kube-play.1.md
make: *** [Makefile:608: xref-helpmsgs-manpages] Error 1

Thank you for feedback!
Of course, I will do it. I marked this PR as draft one until solution is approved.

Signed-off-by: Oleksandr Krutko <alexander.krutko@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants