-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Support spec.replicas > 1 in podman play kube — allow multiple Deployment replicas #27175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Oleksandr Krutko <alexander.krutko@gmail.com>
Signed-off-by: Oleksandr Krutko <alexander.krutko@gmail.com>
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: arsenalzp The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Oleksandr Krutko <alexander.krutko@gmail.com>
@arsenalzp good start on this, TYVM! I agree with @flouthoc 's comments, and we'll need some tests added before we can merge this. |
And you'll need to tweak the man pages a bit per the CI:
|
Thank you for feedback! |
Signed-off-by: Oleksandr Krutko <alexander.krutko@gmail.com>
Hello,
This PR is solving the issue #26769.
I decided to introduce this PR as draft one, because the issue doesn't have solid decision on publish port behavior.
The code introduces a new option
--multiple-pods
, which allows users to create multiple Pods (Deployment.spec.replicas > 1) and it changes--publish
option behavior as user has to setSo, the idea is to use as many publishing ports as many Replicas is created, therefore it is user's responsibility on which ports are used on host side; no need to take random ports as those port might be blocked on firewalls, etc.
For example, if Replicas = 2 then it is necessary to use option
--publish
with8080:80,8081:80
value.Once final decision on this solution is approved then I will update Docs and crate tests
Does this PR introduce a user-facing change?
No