Skip to content

Conversation

inknos
Copy link
Collaborator

@inknos inknos commented Sep 30, 2025

Fixes: #26016

Does this PR introduce a user-facing change?

Fail fast for `podman system connection add` when id file does not exist or has bad permissions

@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Sep 30, 2025
Copy link
Contributor

openshift-ci bot commented Sep 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: inknos
Once this PR has been reviewed and has the lgtm label, please assign mheon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@inknos inknos marked this pull request as draft September 30, 2025 15:35
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2025
@inknos inknos force-pushed the issue-26016 branch 2 times, most recently from 1500121 to 3125ae2 Compare September 30, 2025 15:55
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@inknos
Copy link
Collaborator Author

inknos commented Sep 30, 2025

thanks @Luap99, didn't know about the comments you addressed. I'll fix it tomorrow morning

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes code wise this is fine, just some minor points about the testing

@inknos inknos marked this pull request as ready for review October 3, 2025 14:16
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2025
Fixes: containers#26016

Signed-off-by: Nicola Sella <nsella@redhat.com>
@openshift-ci openshift-ci bot added release-note and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Oct 3, 2025
@TomSweeneyRedHat
Copy link
Member

LGTM
once the unhappy tests are happy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(Windows): using podman system connection add with a ~ should convert it to absolute path
3 participants