-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Stat Identity file on sys con add #27199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: inknos The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1500121
to
3125ae2
Compare
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
thanks @Luap99, didn't know about the comments you addressed. I'll fix it tomorrow morning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes code wise this is fine, just some minor points about the testing
Fixes: containers#26016 Signed-off-by: Nicola Sella <nsella@redhat.com>
LGTM |
Fixes: #26016
Does this PR introduce a user-facing change?