build: allow to build without cgo on RISC-V

[giuseppe]

a few fixes to allow building on platforms where cgo is not available.

The generated podman is not really usable, as it misses the support for shm locking. Should we restore back file locking in this case?

Rootless support is also missing.

These two updates are also required (I'll revendor once they are merged):

containers/storage#375
containers/psgo#53

@carlosedp I could build podman for RISC-V using these commands:

export GO=/path/to/riscv-go/bin/go
export BUILDTAGS_CROSS="containers_image_openpgp containers_image_ostree_stub exclude_graphdriver_btrfs exclude_graphdriver_devicemapper exclude_disk_quota"
make bin/podman.cross.linux.riscv64

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [giuseppe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mheon]

Locking is an interface, so it should be possible to redo SHM locking within the new system. Would need a config knob to select which locking implementation to use.

…

On Wed, Jun 26, 2019, 07:04 OpenShift CI Robot ***@***.***> wrote: @giuseppe <https://github.com/giuseppe>: The following test *failed*, say /retest to rerun them all: Test name Commit Details Rerun command ci/prow/lint 50c4e45 <50c4e45> link <https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/containers_libpod/3437/pull-ci-containers-libpod-master-lint/6360> /test lint Full PR test history <https://prow.svc.ci.openshift.org/pr-history?org=containers&repo=libpod&pr=3437>. Your PR dashboard <https://prow.svc.ci.openshift.org/pr?query=is:pr+state:open+author:giuseppe>. Please help us cut down on flakes by linking to <https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests> an open issue <https://github.com/containers/libpod/issues?q=is:issue+is:open> when you hit one in your PR. Instructions for interacting with me using PR comments are available here <https://git.k8s.io/community/contributors/guide/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. I understand the commands that are listed here <https://go.k8s.io/bot-commands>. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#3437>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB3AOCCLZFSAOISJXPUB3W3P4NEKZANCNFSM4H3Q7IMQ> .

[giuseppe]

I've added a file locking mechanism that can be used instead of the SHM locking, this should unblock us when cgo is not available.

I've also re-vendored containers/storage and containers/psgo, so that they are usable without cgo as well.

@carlosedp I guess it can be used on RISC-V now :-)

[rhatdan]

LGTM

[carlosedp]

Testing it right now. I'll report back in a few.

[carlosedp]

@giuseppe I've successfully built podman on the SiFive Unleashed board (real hardware)! I also built crun and conmon to support it.

➜ go build -tags "containers_image_openpgp containers_image_ostree_stub exclude_graphdriver_btrfs exclude_graphdriver_devicemapper exclude_disk_quota" ./cmd/podman

➜ ./podman --version
podman version 1.4.4-dev
WARN[0000] unable to find /home/carlosedp/.config/containers/registries.conf. some podman (image shortnames) commands may be limited

➜ sudo cp ../conmon/bin/conmon /usr/local/bin
 
➜ ./podman --runtime=/usr/local/bin/crun
Error: could not get runtime: this function is not supported on this os
WARN[0000] unable to find /home/carlosedp/.config/containers/registries.conf. some podman (image shortnames) commands may be limited

Checking what's required to run the full podman stack.

[giuseppe]

@carlosedp rootless won't work without cgo :/ you'll need to use root

[giuseppe]

also you need to set lock_type ="file" in /etc/containers/libpod.conf

[rhatdan]

LGTM

[rh-atomic-bot]

☔ The latest upstream changes (presumably #3324) made this pull request unmergeable. Please resolve the merge conflicts.

[rhatdan]

@giuseppe Needs a rebase.

[giuseppe]

rebased and tests are passing

[rh-atomic-bot]

☔ The latest upstream changes (presumably #3469) made this pull request unmergeable. Please resolve the merge conflicts.

[carlosedp]

Oh gosh, new rebase needed @giuseppe ...

[giuseppe]

rebased again!

/cc @mheon @baude

[mheon]

Theoretically the file locks ought to respect the max locks number in the libpod runtime config... But I don't really think that's worth blocking over. LGTM overall.

[rhatdan]

/lgtm