-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quota: add build tag to disable it #375
Conversation
LGTM |
576e3c8
to
1cbc0a3
Compare
the CI failure doesn't seem related to the PR |
@nalind PTAL |
Looks reasonable. If we're not going to export the newly-added error for direct comparison (it would have to be moved to a place where it's unconditionally declared), then it might as well be allocated at the sites where it's being returned, so that a backtrace ends at the right place. It's okay to merge in its current form, though. |
change backported from Moby. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
1cbc0a3
to
a7a6b09
Compare
thanks, I've updated the PR and now the error is allocated where it is returned |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Restarted the flaked job. Good to merge once we're green :-) |
change backported from Moby.
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com