podman version and --version: fix format, exit

[edsantiago]

Three unrelated fixes to version output:

• podman version --format json: was missing a newline

• podman version --format TEMPLATE: had too many newlines

• podman --version: would neither display version nor exit
  if followed by a subcommand ('podman --version ps')

The first two were easy: I used my best tweezers to delicately
pluck and transfer the misplaced \n and place it where needed.

The third was a doozy of a rabbit hole. As best I can tell,
a workaround was added in root.go to override cobra's built-in
Version handling, apparently to avoid having cobra add "-v"
as an alias for "--version". As best I can tell, cobra only
does this if the "-v" shortcut is not already taken (at
least as of Nov 2019: spf13/cobra#996 ).
Also as best I can tell that workaround is purely vestigial,
and removing it is safe. I've manually tested "-v" in podman run,
system df, and rm. I've run system tests.

Signed-off-by: Ed Santiago santiago@redhat.com

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [edsantiago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[edsantiago]

@jwhonce @baude this involves cobra magic, PTAL

[mheon]

The third thing you call out was to ensure that podman run -v was available as an alias for --volume (and also to ensure that podman run --version, wierd as that might be, continued to work, AFAIK).

[edsantiago]

ensure that podman run -v was available as an alias for --volume

It does; I tried to mention that in my commit message (EDIT: because it would be a complete showstopper if it didn't)

also to ensure that podman run --version, wierd as that might be, continued to work

Um, that doesn't work, nor does it work in released podman. I would consider it a bug if it did work...?

[rhatdan]

LGTM

[TomSweeneyRedHat]

LGTM
tests out well and works as noted by @edsantiago . I'm going to throw on a hold in case @mheon still has questions.

[TomSweeneyRedHat]

/lgtm
/hold

[rhatdan]

/hold cancel