Add short version flag -v when not otherwise set #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
This was referenced Nov 26, 2019
|
@eparis would you mind having a look at this? |
|
ping @jharshman, maybe? |
jharshman
approved these changes
Feb 20, 2020
jharshman
added
the
kind/feature
|
Thanks @jharshman! Can this be merged? Or does it need more approvals? |
|
@jharshman @bep @eparis @broady I wonder if one of you could please merge this? |
|
@hairyhenderson - yes, I was just giving it another once over. |
|
Thanks @jharshman, I appreciate it! |
|
@jharshman any possibility of getting a v0.0.7 cut? No rush - until then I can just use |
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Sep 15, 2020
Three unrelated fixes to version output:
* podman version --format json: was missing a newline
* podman version --format TEMPLATE: had too many newlines
* podman --version: would neither display version nor exit
if followed by a subcommand ('podman --version ps')
The first two were easy: I used my best tweezers to delicately
pluck and transfer the misplaced \n and place it where needed.
The third was a doozy of a rabbit hole. As best I can tell,
a workaround was added in root.go to override cobra's built-in
Version handling, apparently to avoid having cobra add "-v"
as an alias for "--version". As best I can tell, cobra only
does this if the "-v" shortcut is not already taken (at
least as of Nov 2019: spf13/cobra#996 ).
Also as best I can tell that workaround is purely vestigial,
and removing it is safe. I've manually tested "-v" in podman run,
system df, and rm. I've run system tests.
Signed-off-by: Ed Santiago <santiago@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #654 by adding a
-vshorthand to the automatically-addedversionflag.-vshorthand is already set--versionflag is already setSigned-off-by: Dave Henderson dhenderson@gmail.com