fix: fixes bug in from_manifest_and_stream. #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames unit_tests so it will run with pytest.
tmathern
approved these changes
Oct 9, 2024
barnjamin
reviewed
Oct 9, 2024
| super().__init__() | ||
| if manifest_data is not None: | ||
| self.from_manifest_data_and_stream(format, manifest_data, stream) | ||
| self.from_manifest_data_and_stream(manifest_data, format, stream) |
There was a problem hiding this comment.
Shouldn't the stream here also be wrapped in a C2paStream?
There was a problem hiding this comment.
The unit test modified in this PR will fail with a hash mismatch if validation_status is checked:
self.assertNotIn("validation_status", reader.json())Wrapping the stream arg before calling init makes the test pass but it seems like it should be done in the Reader init
There was a problem hiding this comment.
Filed a PR for this so it didn't get lost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames unit_tests so it will run with pytest.