Skip to content

Conversation

tmathern
Copy link
Collaborator

@tmathern tmathern commented Nov 14, 2024

Reexport some uniffi types for type sharing in-between generated Python packages.

Caveat: Python packages sharing the types need exact match of maturin+uniffi version.

@tmathern tmathern changed the title Tmp feat: Reexport some uniffi types for type sharing in-between generated Python packages Nov 14, 2024
@tmathern tmathern changed the base branch from main to mathern/updates November 14, 2024 21:55
@tmathern tmathern requested review from dyro and gpeacock November 14, 2024 22:04
@tmathern tmathern self-assigned this Nov 14, 2024
Base automatically changed from mathern/updates to main November 14, 2024 23:23
@gpeacock
Copy link
Contributor

I updated my makefile to build rust and run pytest like this:

release:
	cargo build --release

build: release
	rm -rf c2pa/c2pa
	python3 -m pip uninstall -y maturin
	python3 -m pip uninstall -y uniffi
	python3 -m pip install -r requirements.txt
	maturin develop

test: build
	python3 -m pytest

Copy link
Contributor

@gpeacock gpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, though you may want to update the makefile to build rust and run unit tests (as in the example I posted)

@tmathern tmathern merged commit 2d971e3 into main Nov 20, 2024
15 checks passed
@tmathern tmathern deleted the mathern/yet-another branch November 20, 2024 21:15
@tmathern tmathern restored the mathern/yet-another branch November 20, 2024 21:15
@tmathern tmathern deleted the mathern/yet-another branch May 7, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants