Fix oauth implementation #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…support - Removed deprecated setOAuthWithPKCE methods and consolidated OAuth configuration into a single setOAuth method. - Updated documentation to clarify clientSecret usage for PKCE flow. - Adjusted error message for missing OAuth configuration to reflect new method usage.
…upport for optional client secret - Simplified setOAuth methods by removing the clientSecret parameter from the primary overloads. - Added a new setOAuth method to accommodate an optional client secret while maintaining PKCE flow. - Updated documentation to reflect changes in method signatures and clarify the use of client secret.
aman19K
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: Simplify OAuth configuration methods and enhance PKCE flow support