Skip to content

fix: added fix for dependency issue and some warnings #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

abhinav-from-contentstack
Copy link
Contributor

  • resolved dependency issues
  • added allowJs: true to tsconfig.json for warnings generated while running unit tests
  • changed objectHashIgnoreUnknownHack to false

Copy link

github-actions bot commented Dec 6, 2023

We regret to inform you that you are currently not able to merge your changes into the master branch due to restrictions applied by our SRE team. To proceed with merging your changes, we kindly request that you create a pull request from the next branch. Our team will then review the changes and work with you to ensure a successful merge into the master branch.

Copy link

github-actions bot commented Dec 6, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 387/387
🟢 Branches 95.94% 189/197
🟢 Functions 100% 108/108
🟢 Lines 100% 363/363

Test suite run success

210 tests passing in 18 suites.

Report generated by 🧪jest coverage report action from 8621af7

@nadeem-cs
Copy link
Contributor

Hey @abhinav-from-contentstack , the SRE restricts merging any feature branch to master branch directly. Please change this PR's base branch to next

Copy link

github-actions bot commented Dec 6, 2023

We regret to inform you that you are currently not able to merge your changes into the master branch due to restrictions applied by our SRE team. To proceed with merging your changes, we kindly request that you create a pull request from the next branch. Our team will then review the changes and work with you to ensure a successful merge into the master branch.

@abhinav-from-contentstack abhinav-from-contentstack changed the base branch from master to next December 6, 2023 11:06
@abhinav-from-contentstack
Copy link
Contributor Author

done @nadeem-cs

Copy link

github-actions bot commented Dec 6, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 387/387
🟢 Branches 95.94% 189/197
🟢 Functions 100% 108/108
🟢 Lines 100% 363/363

Test suite run success

210 tests passing in 18 suites.

Report generated by 🧪jest coverage report action from 8621af7

Copy link

github-actions bot commented Dec 6, 2023

We regret to inform you that you are currently not able to merge your changes into the master branch due to restrictions applied by our SRE team. To proceed with merging your changes, we kindly request that you create a pull request from the next branch. Our team will then review the changes and work with you to ensure a successful merge into the master branch.

1 similar comment
Copy link

github-actions bot commented Dec 6, 2023

We regret to inform you that you are currently not able to merge your changes into the master branch due to restrictions applied by our SRE team. To proceed with merging your changes, we kindly request that you create a pull request from the next branch. Our team will then review the changes and work with you to ensure a successful merge into the master branch.

@abhinav-from-contentstack abhinav-from-contentstack marked this pull request as ready for review December 6, 2023 11:09
@abhinav-from-contentstack abhinav-from-contentstack requested a review from a team as a code owner December 6, 2023 11:09
Copy link

github-actions bot commented Dec 6, 2023

We regret to inform you that you are currently not able to merge your changes into the master branch due to restrictions applied by our SRE team. To proceed with merging your changes, we kindly request that you create a pull request from the next branch. Our team will then review the changes and work with you to ensure a successful merge into the master branch.

@abhinav-from-contentstack
Copy link
Contributor Author

the workflow is still reading the base branch as master

Copy link

github-actions bot commented Dec 6, 2023

We regret to inform you that you are currently not able to merge your changes into the master branch due to restrictions applied by our SRE team. To proceed with merging your changes, we kindly request that you create a pull request from the next branch. Our team will then review the changes and work with you to ensure a successful merge into the master branch.

4 similar comments
Copy link

github-actions bot commented Dec 6, 2023

We regret to inform you that you are currently not able to merge your changes into the master branch due to restrictions applied by our SRE team. To proceed with merging your changes, we kindly request that you create a pull request from the next branch. Our team will then review the changes and work with you to ensure a successful merge into the master branch.

Copy link

github-actions bot commented Dec 6, 2023

We regret to inform you that you are currently not able to merge your changes into the master branch due to restrictions applied by our SRE team. To proceed with merging your changes, we kindly request that you create a pull request from the next branch. Our team will then review the changes and work with you to ensure a successful merge into the master branch.

Copy link

github-actions bot commented Dec 6, 2023

We regret to inform you that you are currently not able to merge your changes into the master branch due to restrictions applied by our SRE team. To proceed with merging your changes, we kindly request that you create a pull request from the next branch. Our team will then review the changes and work with you to ensure a successful merge into the master branch.

Copy link

github-actions bot commented Dec 6, 2023

We regret to inform you that you are currently not able to merge your changes into the master branch due to restrictions applied by our SRE team. To proceed with merging your changes, we kindly request that you create a pull request from the next branch. Our team will then review the changes and work with you to ensure a successful merge into the master branch.

@nadeem-cs
Copy link
Contributor

@abhinav-from-contentstack The action seems to be taking the original base branch. Let's close this and raise a fresh PR.

harshithad0703
harshithad0703 previously approved these changes Dec 8, 2023
@harshithad0703 harshithad0703 dismissed their stale review December 8, 2023 06:56

1 checks failing

@abhinav-from-contentstack
Copy link
Contributor Author

Closing this PR as the Check branch github action is unable to identify that base branch has been changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants