Fix issues in install script #246
Merged
+10
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
a-kurago
commented
Sep 22, 2025
a-kurago
commented
- Removed unused symbols to improve readability and reduce clutter in download-latest.sh.
- Adjusted file permissions to 755 for executables in download-latest.sh.
- Fix color variable definitions. Some colors were printed incorrectly.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes several issues in the download-latest.sh install script to improve functionality and readability. The changes focus on fixing color variable definitions and adjusting file permissions for better cross-platform compatibility.
- Fixed color variable definitions by using printf to properly escape ANSI codes
- Removed unused symbol definitions to reduce clutter
- Changed chmod from +x to 755 for more explicit permission setting
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
butschster
approved these changes
Sep 24, 2025
|
@a-kurago Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.