Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packet processing test for the network stack. #900

Merged
merged 2 commits into from
Sep 26, 2019

Conversation

nvt
Copy link
Member

@nvt nvt commented Apr 16, 2019

This PR adds a parsing test with binary input files that have been known to cause crashes or hangs in the network stack. Current targets are the sicslowpan and uip input functions, but more can be added later.

At the time of posting this, the test is expected to fail on the current develop branch, but PRs are being prepared to fix the issues.

Some statistics from different combinations of branches in my contiki-ng repo:

  • Branch: develop

packet-injector-uip TEST FAIL
Succeeded: 13
Timed out: 7
Failed : 15

packet-injector-sicslowpan TEST FAIL
Succeeded: 28
Timed out: 7
Failed : 31

  • Branch: develop + fix-rpl-ext-header-removal

packet-injector-uip TEST OK
Succeeded: 35
Timed out: 0
Failed : 0

packet-injector-sicslowpan TEST FAIL
Succeeded: 41
Timed out: 0
Failed : 25

  • Branch: develop + fix-rpl-ext-header-removal + check-uip-len

packet-injector-uip TEST OK
Succeeded: 35
Timed out: 0
Failed : 0

packet-injector-sicslowpan TEST FAIL
Succeeded: 41
Timed out: 0
Failed : 25

  • Branch: develop + fix-rpl-ext-header-removal + check-uip-len + sicslowpan-reassembly-fixes

packet-injector-uip TEST OK
Succeeded: 35
Timed out: 0
Failed : 0

packet-injector-sicslowpan TEST OK
Succeeded: 66
Timed out: 0
Failed : 0

@nvt nvt changed the title Packet parsing test for the communication stack. Packet processing test for the network stack. Apr 16, 2019
@nvt nvt force-pushed the uip-crash-test branch 3 times, most recently from 6986358 to 0d7ff77 Compare April 16, 2019 13:55
Copy link
Member

@simonduq simonduq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWESOME 👏👏

@simonduq
Copy link
Member

Please now for the fixes! :)

@g-oikonomou g-oikonomou added this to the Version 4.4 milestone Aug 31, 2019
@g-oikonomou g-oikonomou self-assigned this Sep 22, 2019
@g-oikonomou g-oikonomou merged commit 7be9a7b into contiki-ng:develop Sep 26, 2019
@nvt nvt deleted the uip-crash-test branch October 9, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants